Mobbeel / fataar-gradle-plugin

Gradle plugin to help embed dependencies in generated AAR artifact
https://plugins.gradle.org/plugin/com.mobbeel.plugin
Apache License 2.0
342 stars 44 forks source link

Crash when renaming jar file #16

Closed jonbryantnz closed 5 years ago

jonbryantnz commented 5 years ago

Hello!

From CopyDependenciesTask.groovy, the line (#191) rename "classes.jar", "${dependency.group.toLowerCase()}-${dependency.name.toLowerCase()}-${dependency.version}.jar" will crash if the dependency object's group or version methods return null.

According to the gradle documentation for the Dependency these methods are annotated as @Nullable (i.e. returning null is a possibility).

Thanks, Jon

PS Cheers for developing this plugin, it's very much appreciated!