Mobbeel / fataar-gradle-plugin

Gradle plugin to help embed dependencies in generated AAR artifact
https://plugins.gradle.org/plugin/com.mobbeel.plugin
Apache License 2.0
340 stars 44 forks source link

Support Gradle plugin 3.2.x. and 3.3.x [Improvement] #28

Open oscarcpozas opened 5 years ago

oscarcpozas commented 5 years ago

Pull request are welcome!

oscarcpozas commented 5 years ago

@stanleychan @TomTasche @m-ivanov @xenixcorp @Hollerweger I'll keep you posted on this issue of the support status to versions 3.2.x and 3.3.x

TomTasche commented 5 years ago

as mentioned in another post, I'd love to contribute here if you give us some hints where to look.

in any case I'm glad to see you are actively working on this issue!

alixwar commented 5 years ago

Working on this but I need some help: https://github.com/Mobbeel/fataar-gradle-plugin/pull/30

TomTasche commented 5 years ago

anyone had time to look into this and at least partially understand what the problem is? I don't know enough about the Gradle internals to figure it out myself

zsajjad commented 5 years ago

Ready to sponsor this development if someone feels he/she can do this perfectly. @oscarcpozas

TomTasche commented 5 years ago

I found a workaround that works for the project I'm working on: combine the code of several modules into one using multiple sourceSets.

sourceSets {
        main {
            java.srcDirs = ['src/main/java', '../OtherModule/src/main/java', '../LastModule/src/main/java']
        }
}

You'll have to copy dependencies from your modules' build.gradle too.

I would consider that a little less clean than using actually different modules, but it's still better than putting all of your code into one directory. You also don't rely on external plugins that potentially need to be updated for every gradle update anymore.

chenenqiang12345 commented 5 years ago

How long does it take to support tool: 3.4.2, gradle: 5.1.1, 3.1 does not support androidX, and many new features are not available! I can provide a way to create an empty application project that relies on various library projects and builds apk. It covers all the final dependencies and resources. The advantage is that we don't need to consider the official Google process, we just need to get it. The final resource processing is fine. We only need to extract useful resources to generate aar or jar packages. I think this is a more appropriate method, because it does not require you to consider the engineering structure and the problems caused by Google's development of new features later! At present, I have tried this. This is feasible. The problem now is that I am going to change it manually. It is more troublesome. I hope that you can directly automate the process! This benefit can be plugged in! I hope that you can take more time to deal with it, I am in urgent need of this function! @oscarcpozas

mochadwi commented 5 years ago

https://github.com/kezong/fat-aar-android/

How long does it take to support tool: 3.4.2, gradle: 5.1.1, 3.1 does not support androidX, and many new features are not available! I can provide a way to create an empty application project that relies on various library projects and builds apk. It covers all the final dependencies and resources. The advantage is that we don't need to consider the official Google process, we just need to get it. The final resource processing is fine. We only need to extract useful resources to generate aar or jar packages. I think this is a more appropriate method, because it does not require you to consider the engineering structure and the problems caused by Google's development of new features later! At present, I have tried this. This is feasible. The problem now is that I am going to change it manually. It is more troublesome. I hope that you can directly automate the process! This benefit can be plugged in! I hope that you can take more time to deal with it, I am in urgent need of this function! @oscarcpozas

You might wanna check kezong fat-aar version, that support 3.4.2