search

MobiFlight / CommunityDevices

MIT License
1 stars 1 forks source link

SPI pins are fixed #2

Open elral opened 6 months ago

elral commented 6 months ago

Description of changes

This display uses the hardware SPI interface, so two pins are fixed and cannot be chosen within the configuration as before. CLK, MOSI and MISO are deleted from the board.json files. CLK and Data are deleted from the device.json as they don't need to be configured anymore. Readme file is updated accordingly.

github-actions[bot] commented 6 months ago

Community folder for this pull request: Community.zip

DocMoebiuz commented 6 months ago

Why is this? I think when I started with this, all pins were freely assignable.

elral commented 6 months ago

Why is this? I think when I started with this, all pins were freely assignable.

Nearly from the beginning on this device uses the HW SPI. Maybe you remember the slow refresh rate if using SW SPI. There too much data to do it this way. SInce then the readme stated to use fixed pins (the HW SPI ones), I think this makes no sense.

Better to exclude them from the board.json and device.json file, it's also an example how to handle this.