MobiFlight / HubHop-Website

2 stars 1 forks source link

Vote mechanism doesn't enforce one up/down vote per user #19

Closed ssewell closed 2 years ago

ssewell commented 3 years ago

Current Behavior

If a user clicks Upvote or Downvote on the details page of a configuration, they can continue to repeatedly do so to arbitrarily increase or decrease the score. In the following screenshot, I've increased the Score from 0 to 10.

image

Expected Behavior

If the user has already voted on a particular item, clicking the same vote icon a subsequent time should remove the vote. In addition, they should be able to change the directly between an upvote and a downvote. Ideally, the current state of their vote would be shown visually by highlighting the selected vote icon.

Example 1: Score is currently 7. User clicks Upvote, score goes to 8. Upvote icon becomes highlighted. User clicks Upvote again, score goes back down to 7.

Example 2: Score is currently 7. User clicks Downvote, score goes to 6. Downvote icon becomes highlighted. User decides they made a mistake, clicks Upvote. Score goes to 8 (since it pulled their downvote and added their upvote).

Video of Described Behavior

Example

rofl-er commented 3 years ago

Thank you @ssewell ! This was the first implementation of the voting system. Sebastian and myself are working on the API to prevent your described behavior. Thank you again!

rofl-er commented 2 years ago

I removed the scoring feature due to the limited use case it had.