search

MobiFlight / MobiFlight-Connector

MobiFlight is an open source project that allows you to create your own home cockpit for your favorite flight simulator in a flexible, affordable and extremely user-friendly way.
https://mobiflight.com
MIT License
234 stars 104 forks source link

MobiFlight always asks me if I want to upload firmware to newly connected devices #1820

Closed rageshkrishna closed 1 month ago

rageshkrishna commented 1 month ago

Describe the bug I have all my cockpit gear connected to a powered USB hub. This consists of 2 Mega's running MobiFlight firmware, a miniFCU running stock firmware, and some ThrustMaster gear. The power button on the hub lets me power up/down the entire kit with a single button. MobiFlight is almost always running in the background for me. When I power on my hub, MobiFlight detects my miniFCU is a compatible module and asks me if I want to upload firmware. I decline, and then it asks me if I want to disable automatic uploads to which I say, "yes".

This, however, does not stop MobiFlight from asking me every time I power up my gear. The "Scan for compatible boards and upload latest firmware" setting in the UI shows that it is unchecked, but it still asks me every time.

Steps To Reproduce

  1. Launch MobiFlight
  2. Power on USB hub with a miniFCU or an unflashed Arduino connected to it
  3. Decline MobiFlight's offer to upload firmware
  4. Accept MobiFlight's offer to disable automatic firmware upload
  5. Power down and up the USB hub

Expected behavior Disabling the "scan for compatible boards and upload latest firmware" option should apply to all newly connected devices.

Actual behavior MobiFlight continues to ask me every time I power up my hub, regardless of the setting

Details

DocMoebiuz commented 1 month ago

i will look into later. In the meantime, right-click on the miniFCU and add it to the ignored Ports list. That should help.

rageshkrishna commented 1 month ago

i will look into later. In the meantime, right-click on the miniFCU and add it to the ignored Ports list. That should help.

Yes, I'm using that as a workaround at the moment. I've opened a PR that will respect the setting and not prompt to install on non-MobiFlight devices.

DocMoebiuz commented 1 month ago

Important detail: you are connecting the modules after startup. That's where the check was missing. Thanks!