Closed neilenns closed 3 years ago
As far as I know how to issue pull requests I will try to make my first one ;) I hope it takes not too much time to figure this out...
@elral the easiest way is if you are in VSCode to use the GitHub Pull Requests and Issues extension.
@danecreekphotography, thanks a lot for your hints. Took some time to understand, and in the end I had to do step 4 on the github page. Didn't find what you explained. Hopefully everything went well. Regards Ralf
I "found" that the original library (in platformio.ini "mathertel/RotaryEncoder @ ^1.5.2") got recently some updates. The button and TicksPerSecond lib is not used anymore. Acceleration can now be done via "::getMillisBetweenRotations()". There are some more little changes in MFEncoder.cpp required (which I prepared already). RAM usage is reduced by ~300Bytes!?
BUT encoders with 4 Steps per cycle are NOT supported anymore. Are there at all these rotary encoder (for inputs, not for detecting shaft rotating w/o detents) existing? For me I never had them and never saw them, only 1 and 1 detents per cycle. Does this somebody know? If they exist and used, plan B has t come (or is it C?)
@elral Just to reduce the amount of churn happening in the firmware in a single release (and there's a lot of combined changes for this PlatformIO move), my suggestion is to stick with what you already did that's based on the current version of the library that's well understood for MobiFlight usage.
From the MobiFlight issue elral has good changes to include: