search

MobiVM / robovm-robopods

55 stars 37 forks source link

Add Yandex AppMetrica robopod #11

Closed alex-dorokhov closed 7 years ago

alex-dorokhov commented 7 years ago

This request adds AppMetrica robopod. It is tested and it works.

There is an issue in YMMYandexMetricaPreloadInfo binding. I wasn't able to make bro-gen to generate methods for it. However, I believe this class is rarely needed, so this can be fixed later by me or someone else.

florianf commented 7 years ago

@Tom-Ski Is this useable?

Tom-Ski commented 7 years ago

Missed this, and I have no idea. If @alex-dorokhov wants to take responsibility for it then seems ok, would be good to have it under bro-gen though.

alex-dorokhov commented 7 years ago

@Tom-Ski I'm ready to take the responsibility, I'm using this library regularly. There is also the yaml file. Or what do you mean by "under bro-gen"?

Tom-Ski commented 7 years ago

Ah sorry, I misunderstood your comment, you used bro-gen but you weren't able to make YMMYandexMetricaPreloadInfo via bro-gen?

alex-dorokhov commented 7 years ago

@Tom-Ski correct. And because of this, YMMYandexMetricaPreloadInfo is absent. All other classes are there and generated with bro-gen.

Tom-Ski commented 7 years ago

Gotcha. Ok sounds good, thanks!