search

MobiVM / robovm

Ahead of time compiler for JVM bytecode targetting iOS, Mac OSX and Linux
https://mobivm.github.io
966 stars 133 forks source link

Subscription APIs mix NSObjectProtocol and NSObject #682

Closed guillerodriguez closed 1 year ago

guillerodriguez commented 2 years ago

Some subscription APIs return a NSObjectProtocol (e.g. UIWindow.observeKeyboardWillShown), however NSNotificationCenter.removeObserver expects a NSObject.

Looks like subscription APIs were switched from NSObject to NSObjectProtocol in this commit. This was later reverted (see commit). However apparently not all cases were reverted.

This affects robovm-2.3.16 upwards and is also present in current master.

dkimitsa commented 2 years ago

@guillerodriguez please check the PR https://github.com/MobiVM/robovm/pull/683 thx

guillerodriguez commented 2 years ago

@dkimitsa LGTM, will test once this lands in a snapshot.

dkimitsa commented 1 year ago

@guillerodriguez its part of 2.3.19 release

guillerodriguez commented 1 year ago

Thank you!