search

MobileChromeApps / chrome-app-developer-tool

Mirror of Apache Cordova app harness
Other
202 stars 33 forks source link

CADT HTTP server doesn't work on Android < KK #22

Closed clelland closed 10 years ago

clelland commented 10 years ago

The HTTP server breaks on older Android versions because of a missing ArrayBuffer.prototype.slice method. We'll need to polyfill that, or to use a different method in the HttpServer.js code.

clelland commented 10 years ago

Fixed with 5fcc666

cyberflohr commented 10 years ago

the above fix will raise the following lint errors during build

[15:39:35] Finished 'lint:harness-push' after 209 ms /Projects/ChromeApps/chrome-app-developer-tool/www/cdvah/js/polyfill/slice.js: line 6, col 15, Strings must use singlequote. /Projects/ChromeApps/chrome-app-developer-tool/www/cdvah/js/polyfill/slice.js: line 9, col 15, Unexpected use of '|'.

2 errors [15:39:35] 'lint:app' errored after 473 ms

agrieve commented 10 years ago

Thanks for pointing this out. Just pushed a fix (moved the file into libs/ so as to be ignored by the linter)

On Fri, Jul 11, 2014 at 9:52 AM, Wolfgang Flohr-Hochbichler < notifications@github.com> wrote:

the above fix will raise the following lint errors during build

[15:39:35] Finished 'lint:harness-push' after 209 ms /Projects/ChromeApps/chrome-app-developer-tool/www/cdvah/js/polyfill/slice.js: line 6, col 15, Strings must use singlequote. /Projects/ChromeApps/chrome-app-developer-tool/www/cdvah/js/polyfill/slice.js: line 9, col 15, Unexpected use of '|'.

2 errors [15:39:35] 'lint:app' errored after 473 ms

— Reply to this email directly or view it on GitHub https://github.com/MobileChromeApps/chrome-app-developer-tool/issues/22#issuecomment-48732506 .

agrieve commented 10 years ago

this is now included in the 0.8.1 release!

On Fri, Jul 11, 2014 at 12:30 PM, Andrew Grieve agrieve@chromium.org wrote:

Thanks for pointing this out. Just pushed a fix (moved the file into libs/ so as to be ignored by the linter)

On Fri, Jul 11, 2014 at 9:52 AM, Wolfgang Flohr-Hochbichler < notifications@github.com> wrote:

the above fix will raise the following lint errors during build

[15:39:35] Finished 'lint:harness-push' after 209 ms /Projects/ChromeApps/chrome-app-developer-tool/www/cdvah/js/polyfill/slice.js: line 6, col 15, Strings must use singlequote. /Projects/ChromeApps/chrome-app-developer-tool/www/cdvah/js/polyfill/slice.js: line 9, col 15, Unexpected use of '|'.

2 errors [15:39:35] 'lint:app' errored after 473 ms

— Reply to this email directly or view it on GitHub https://github.com/MobileChromeApps/chrome-app-developer-tool/issues/22#issuecomment-48732506 .

cyberflohr commented 10 years ago

just tested 0.8.1, works like a charm - thank you! :-)