MobileChromeApps / cordova-plugin-chrome-apps-sockets-tcp

BSD 3-Clause "New" or "Revised" License
44 stars 52 forks source link

Fix TCP packet reordering on android, "unknown socket id" on iOS #27

Open mcelrath opened 7 years ago

mcelrath commented 7 years ago

Calling readyToRead as this code does on Android causes TCP packets to be assembled in an incorrect order, resulting in stream data corruption.

However it seems calling readyToRead on iOS is absolutely necessary, or you won't get any data at all.

Fixes #14 and #26

googlebot commented 7 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


mcelrath commented 7 years ago

I signed it!