search

MobileChromeApps / cordova-plugin-service-worker

163 stars 37 forks source link

Add service worker ready promise #3

Closed imintz closed 9 years ago

imintz commented 9 years ago

Alright, I'll make the fix and resubmit the pull request. But first, are there any other glaring issues that need to be fixed prior to the resubmit?

mwoghiren commented 9 years ago

I left a bunch of comments (mostly minor)—feel free to just pack fixes into one commit (or reply with pushback if you disagree on something). :)

On Thu, Feb 19, 2015 at 12:17 PM, imintz notifications@github.com wrote:

Alright, I'll make the fix and resubmit the pull request. But first, are there any other glaring issues that need to be fixed prior to the resubmit?

— Reply to this email directly or view it on GitHub https://github.com/mwoghiren/cordova-plugin-serviceworker/pull/3#issuecomment-75094366 .