search

MobileChromeApps / mobile-chrome-apps

Chrome apps on Android and iOS
BSD 3-Clause "New" or "Revised" License
2.5k stars 348 forks source link

cca will delete the `xwalkVersion` when updating the config.xml #592

Closed fujunwei closed 8 years ago

fujunwei commented 8 years ago

The latest Crosswalk Cordova plugin support default variables at install time. The xwalkVersion will be configured in the config.xml with hooks with default value, it will be deleted at uninstall time. so the cca need align with it.

You can also use following command to specify the version when installing the plugin

cordova plugin add cordova-plugin-crosswalk-webview --variable xwalkVersion="15+"

Don't delete the preference in the cca/node_modules/cca-manifest-logic/src/update-config-xml.js

if (analyzedManifest.engineName == 'crosswalk' && analyzedManifest.engineVer) {
      setOrCreatePreference('xwalkVersion', analyzedManifest.engineVer);
  } else {
      deletePreference('xwalkVersion');
  }
dennice13 commented 8 years ago

Bye and wellcome to hello world by google

dennice13 commented 8 years ago

Bye and wellcome to hello world by google

Honry commented 8 years ago

We can still reproduce this issue, anyone can help take a look? I will be very appreciate.

agrieve commented 8 years ago

For CCA apps, you can set the crosswalk version in the manifest.mobile.json file, so this behaviour is intended. I've updated the docs to mention how you do this.

Honry commented 8 years ago

This way can only specify Crosswalk stable version, what about Crosswalk beta?

Honry commented 8 years ago

@agrieve, could you please clarify if cca would support crosswalk beta configuration?