search

MobileFirstLLC / extension-cli

Command line tool for building extensions/add-ons for chromium based browsers.
https://oss.mobilefirst.me/extension-cli
MIT License
172 stars 25 forks source link

ACTION: chalk breaking change #155

Open nicolas377 opened 2 years ago

nicolas377 commented 2 years ago

About a month ago, I merged #134 into master, which was a breaking version of chalk. I hadn't properly tested the change, and it seems that chalk has changed directions to use ESM, and not support CommonJS. This can be demonstrated by using the current state of master (at commit 4684574c16afa04af4bc6b797d4837b5bfaae84d), and running npx extension-cli. You should see this error (unneeded dirs blacked out):

image

I'll be working on fixing this, but this will remain a tracking issue.

nicolas377 commented 2 years ago

@nkrusch wanted to ping you to let you know about this

nicolas377 commented 2 years ago

I'm going to commit a temporary fix to this, which will just be a reversion to chalk v4. At that point, I'll start work on a PR to use ESM (we may potentially need to use module bundling for that).

nicolas377 commented 2 years ago

@nkrusch I've gotten the master version stable. I won't be making any new commits to master for a while, so if you want to, now would be a great time to do a patch release.