Closed DZamataev closed 10 years ago
K, understood will get a fix out today if possible. Thanks,
+1
I'm in the process of rewriting SuProgress so it has the flexibility for reset
and also so the progress bar itself is pinned to the viewController's frame rather than the navbar's frame, so expect a new push soon (ish).
For now a work around is just to call stop-loading on the UIWebView
in the ViewController's dealloc
.
Ok, thats nice! Thank you. Will try it.
2013/11/8 Max Howell notifications@github.com
I'm in the process of rewriting SuProgress so it has the flexibility for reset and also so the progress bar itself is pinned to the viewController's frame rather than the navbar's frame, so expect a new push soon (ish).
For now a work around is just to call stop-loading on the UIWebView in the ViewController's dealloc.
— Reply to this email directly or view it on GitHubhttps://github.com/MobileMakersAcademy/SuProgress/issues/5#issuecomment-28076688 .
Also noticed that SuProgress prevents my ViewController from being deallocated both at navigation pop and modal dismiss. This issue stops me from using SuProgress by default for now. Looking forward to future releases with the ability to stop and clear the mess. Thanks!
The whole view controller? That doesn't make sense to me. SuProgress doesn't keep any pointers to the view controller. I'll investigate.
The view controller doesn't get deallocated because the endDelegate property is set as strong (Default in ARC for an object). I'll send a quick pull request fixing that.
@kvting @mxcl Thanks! That works!
In my application user can stop loading the page in webView by navigating back via back bar button item in navigation controller. I want to remove SuProgressBarView from navigation bar and stop it's logic including status bar progress indicator spinning. I have problems doing that, because
So what i do for now is hiding and showing the SuProgressBar because i am not able to safely remove it from existing navigation bar using public methods or somehow.