search

MobileNativeFoundation / Store

A Kotlin Multiplatform library for building network-resilient applications
https://mobilenativefoundation.github.io/Store/
Apache License 2.0
3.16k stars 197 forks source link

Switch from ktlint -> ktfmt #116

Open eyalgu opened 4 years ago

eyalgu commented 4 years ago

It seems like ktlint keeps triping me up because it doesn't support running as part of the workflow (I make a small change, forget to fix some spacing then get a failure). I'd like to try out https://github.com/facebookincubator/ktfmt. I know the maintainers and would love to give it a try

ychescale9 commented 4 years ago

Hmm looks like there's no published artifact yet and it requires maven 🙃?

eyalgu commented 4 years ago

Yeah, I would check in a binary

On Wed, Feb 19, 2020, 6:05 PM Yang notifications@github.com wrote:

Hmm looks like there's no published artifact yet and it requires maven 🙃?

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/dropbox/Store/issues/116?email_source=notifications&email_token=AAMUYKLDDG5Z33KBFIY6FHTRDXQPLA5CNFSM4KX6B6UKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEMKOKGI#issuecomment-588571929, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAMUYKK3SGPCIXJNGX2JJMTRDXQPLANCNFSM4KX6B6UA .

tasomaniac commented 4 years ago

ktfmt is not a full replacement, right? ktlint is a formatter but also a linter.

cgrushko commented 4 years ago

@ychescale9 @eyalgu we started publishing artifacts to Maven Central: https://search.maven.org/artifact/com.facebook/ktfmt/0.12/jar

@tasomaniac correct; ktfmt is a code formatter. It's analogous to google-java-format in the Java world.

cgrushko commented 4 years ago

https://github.com/diffplug/spotless/pull/569 is bringing ktfmt to Spotless. I see Store already uses Spotless, so it should be easy to try out ktfmt.

biratdatta commented 2 years ago

Yeah it is a good issue, require a discussion for it.