A bit of context: we are currently looking at using cache as a dependency to apollo-kotlin's in-memory cache to improve performance with concurrency. Apollo Kotlin has the wasm target enabled so this change would come in handy for us.
Type of Change
[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update
Test Plan
Added a few basic tests for Cache, and ensured ./gradlew :cache:wasmJsTest passes
Checklist:
Before submitting your PR, please review and check all of the following:
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
Didn't see a list of targets in the documentation, so didn't touch anything - let me know if I missed it
[x] My changes generate no new warnings
[x] I have added tests that prove my change is effective
[x] New and existing unit tests pass locally with my changes
Additional Notes:
Also adds the target to core since it's a dependency of cache
I had to upgrade a few dependencies which resulted in a few tweaks to the gradle files
Also had to specify Java 11 as the target - using 17 triggers KT-60197 (see also this one)
Description
Adds the
wasmJstarget to thecachemodule.A bit of context: we are currently looking at using
cacheas a dependency to apollo-kotlin's in-memory cache to improve performance with concurrency. Apollo Kotlin has the wasm target enabled so this change would come in handy for us.Type of Change
Test Plan
Added a few basic tests for Cache, and ensured
./gradlew :cache:wasmJsTestpassesChecklist:
Before submitting your PR, please review and check all of the following:
Additional Notes:
coresince it's a dependency ofcache