MobileNativeFoundation / Store

A Kotlin Multiplatform library for building network-resilient applications
https://mobilenativefoundation.github.io/Store/
Apache License 2.0
3.16k stars 197 forks source link

Add Cache.getAllPresent() #609

Closed BoD closed 5 months ago

BoD commented 6 months ago

Description

Adds getAllPresent() with no argument to Cache, in addition to existing getAllPresent(keys: List<*>). In the original Guava library there was an asMap() method which could be used to get the contents of the cache.

Type of Change

Test Plan

Removed @Ignore from the getAllPresent() test.

Checklist:

Before submitting your PR, please review and check all of the following:

Additional Notes:

Used clear() as an inspiration for the implementation.

BoD commented 6 months ago

Please document the default method, otherwise LGTM and I will be around to stamp. I see the other tickets - when do you need a release?

🙏 I've addressed the comments 👍

A release is not urgent, for now we've bundled the classes in the project - whenever you make a release, we'll use the dependency instead.