MobileNativeFoundation / Store

A Kotlin Multiplatform library for building network-resilient applications
https://mobilenativefoundation.github.io/Store/
Apache License 2.0
3.16k stars 197 forks source link

Update ChannelManager.kt #637

Closed lukisk closed 3 months ago

lukisk commented 3 months ago

Closes #636

Description

The cancellation exception on upstream channel does not cause the closure of all other channels.

Type of Change

Test Plan

How has this been tested? Please describe the tests that you added to verify your changes.

Checklist:

Before submitting your PR, please review and check all of the following:

Additional Notes:

The cancellation exception from the upstream channel was caught in the StoreActor while handling messages. This caused the closure of the actor.

digitalbuddha commented 3 months ago

Good catch! Do you mind adding a test to prove the functionality?

lukisk commented 3 months ago

yes, i will do it

lukisk commented 3 months ago

@digitalbuddha please, can you check it?