fix: lower JVM target to Java 11 - Githubissues

MobileNativeFoundation / Store

A Kotlin Multiplatform library for building network-resilient applications

https://mobilenativefoundation.github.io/Store/

Apache License 2.0

3.16k stars 197 forks source link

fix: lower JVM target to Java 11 #648

Closed msfjarvis closed 2 months ago

msfjarvis commented 2 months ago

Related to #640

Description

Lowers JVM target to 11 as a workaround for https://github.com/Kotlin/dokka/issues/2956

Type of Change

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Test Plan

Disabled signing and did a local publish with gradle publishToMavenLocal which successfully generated documentation.

Checklist:

Before submitting your PR, please review and check all of the following:

[x] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ] I have added tests that prove my change is effective
[x] New and existing unit tests pass locally with my changes

Additional Notes:

Add any other information about the PR here.

matt-ramotar commented 2 months ago

Thanks @msfjarvis 👍🏽 - I think we'll want to make these updates too https://github.com/MobileNativeFoundation/Store/pull/649