search

MobileNativeFoundation / XCLogParser

Tool to parse Xcode and xcodebuild logs stored in the xcactivitylog format
Apache License 2.0
1.74k stars 123 forks source link

Add IDEActivityLogActionMessage support #189

Closed mollyIV closed 10 months ago

mollyIV commented 11 months ago

Closes https://github.com/MobileNativeFoundation/XCLogParser/issues/187.

Add IDEActivityLogActionMessage support.

BalestraPatrick commented 11 months ago

@mollyIV Sorry for the delay! Do you mind fixing the DCO check and possibly add a few tests? There's a test class for this specific logic which we can use.

mollyIV commented 10 months ago

Hey @BalestraPatrick 👋

No worries 😊 I fixed DCO check and added a unit test. Thanks for pointing to a test class. Let me know if there's anything else I can do, thanks!

BalestraPatrick commented 10 months ago

Looks good to me! One minor linter failure which you can disable with // swiftlint:disable file_length.

danielPeloton commented 10 months ago

Thanks for pushing this through!

Is there a plan to get this into a new release?