search

MobileNativeFoundation / bluepill

Bluepill is a reliable iOS testing tool that runs UI tests using multiple simulators on a single machine
BSD 2-Clause "Simplified" License
3.19k stars 232 forks source link

Fail if bp binary is not found adjacent to bluepill and also some refactoring #378

Closed ravimandala closed 4 years ago

ravimandala commented 4 years ago

Do not look for bp binary on PATH and simply fail if it is not found adjacent to the bluepill binary.

Also did some refactoring, cleanup and improvements like...

  1. Moved a helper method to utils
  2. Enhancing error messages and better error handling
  3. Fixing asserts in tests
  4. Renaming variables

\cc @ob @jmkk Please review.

ob commented 4 years ago

Can you rebase on master? Apparently the CI doesn't kick in unless the PR is against master. Also, I think we should develop on master and cherry pick back to the appropriate branch if needed.

ravimandala commented 4 years ago

I repurposed this PR to merge changes from https://github.com/linkedin/bluepill/pull/379 and https://github.com/linkedin/bluepill/pull/380 into v4.1.1+packing branch.

Testing done: Build and test locally.

@ob Can you please take another look?