search

MobileNativeFoundation / bluepill

Bluepill is a reliable iOS testing tool that runs UI tests using multiple simulators on a single machine
BSD 2-Clause "Simplified" License
3.19k stars 232 forks source link

Record video using simctl #441

Closed RainNapper closed 3 years ago

RainNapper commented 4 years ago

Use the XCTest listener protocol to add hooks for xcrun simctl io [sim-id] recordVideo.

RainNapper commented 4 years ago

Nice! Thanks for contributing this feature.

Could we add a test case that actually records video for a test and checks that video was recorded? I think it could be wired in one of the tests that runs BPSampleApp.

Added a test in the last push.

kinwahlai commented 4 years ago

Hi there, you may want to allow the user to change the codec option, h264 or hevc. The default is hevc but slack cannot play hevc video file.

Suggestion: new option deleteOnTestPassed , meaning delete video if the test passed. It can reduce the number of Videos stored on the CI machine.

Cool feature by the way.

RainNapper commented 3 years ago

Hi there, you may want to allow the user to change the codec option, h264 or hevc. The default is hevc but slack cannot play hevc video file.

Suggestion: new option deleteOnTestPassed , meaning delete video if the test passed. It can reduce the number of Videos stored on the CI machine.

Cool feature by the way.

Totally agree. bp is pretty heavy on the configs atm, mind adding this as a follow up PR?

ravimandala commented 3 years ago

Hi there, you may want to allow the user to change the codec option, h264 or hevc. The default is hevc but slack cannot play hevc video file.

Suggestion: new option deleteOnTestPassed , meaning delete video if the test passed. It can reduce the number of Videos stored on the CI machine.

Cool feature by the way.

@RainNapper I like @kinwahlai's suggestion. The deleteOnTestPassed can either be a config, or the default behavior too. It would be great if you can create an issue to discuss and follow it up with a PR. Thanks for the contribution.