When parsing an XML result file fails, don't fail while merging subsequent test results

MobileNativeFoundation / bluepill

Bluepill is a reliable iOS testing tool that runs UI tests using multiple simulators on a single machine

BSD 2-Clause "Simplified" License

3.18k stars 231 forks source link

When parsing an XML result file fails, don't fail while merging subsequent test results #515

Closed jschear closed 2 years ago

jschear commented 2 years ago

Presently, when parsing an XML result file fails, all subsequent reports are skipped because the NSError instance is being reused. This PR fixes that issue and adds a test case.

jschear commented 2 years ago

I'm not sure if the failing check is related to my changes. It looks like the same test failed on master: https://github.com/MobileNativeFoundation/bluepill/runs/3747110142?check_suite_focus=true

ravimandala commented 2 years ago

I saw some executions where this happened and I see how this could skip the subsequent reports that might be perfectly valid. Thanks again for the fix.