search

MobileNativeFoundation / bluepill

Bluepill is a reliable iOS testing tool that runs UI tests using multiple simulators on a single machine
BSD 2-Clause "Simplified" License
3.18k stars 231 forks source link

Fix how the test host app is made into a .app #529

Closed dostrander closed 2 years ago

dostrander commented 2 years ago

In the previous was we would rstrip the test_host's app extension. If this happened to be the same as the end of the app name it would strip that too. For example if it was Foo-App.app it would change to Foo-A.app.

This updates to take whatever is before the app extension by splitting the test_host's extension + '.' and taking the first entry.

This fixes https://github.com/MobileNativeFoundation/bluepill/issues/528

dostrander commented 2 years ago

I didn't see any tests for the bazel test rule. If there are please point me in the right direction

ob commented 2 years ago

I didn't see any tests for the bazel test rule. If there are please point me in the right direction

Yeah, the bazel rule is... shall we say "light on testing" 😅

ob commented 2 years ago

@dostrander All that is missing is the DCO step. Can you add the Signed-off-by: line? There's instructions in the failed test details. Thanks!

dostrander commented 2 years ago

@ob should be updated now