MobileOrg / mobileorg

MobileOrg iPhone App
http://mobileorg.github.io
GNU General Public License v2.0
556 stars 69 forks source link

Bugfix/@objc in swift 4 #234

Closed michaeleverson closed 5 years ago

michaeleverson commented 5 years ago

Perhaps you had a grander plan here, so I understand if you don't want to pull this, but while I was trying to figure out why syncing was broken, I cleared up the @objc related warnings and bumped the version of the Dropbox pod.

Kind regards, Michael.

webframp commented 5 years ago

@michaeleverson thanks for the contribution! I'm ok with making the jump for the SwiftyDropbox dep but would like to see the ci passing before merging. Any thoughts on the failures to do the pod install?

michaeleverson commented 5 years ago

Hi @webframp,

I had a look at this. The problem is that the CocoaPods dependencies database on TravisCI is out of date. We can fix it by add this to the .travis.yml:

install:
  pod install --repo-update 

This change lets this request pass the travis-ci.

webframp commented 5 years ago

Looks good @michaeleverson thanks!