MobileOrg / mobileorg

MobileOrg iPhone App
http://mobileorg.github.io
GNU General Public License v2.0
556 stars 69 forks source link

Dynamic type support + Appearance improvements #248

Closed dive closed 4 years ago

dive commented 4 years ago

Hello there,

Changes

This is the base implementation of the new cell to render tasks with the following features:

There is a huge room for improvements, but I am going to apply them later to keep changesets meaningful.

Note for a reviewer

The only concern I have is about beforeText/afterText. I have removed support for both because I did not find any references and how they used. Maybe I am wrong and we need these fields.

These changes resolve #204.

Examples

Small video is available here.

Small Font XXL Font Light Theme
mobileorg-dynamic-type-dark-theme-small-font mobileorg-dynamic-type-dark-theme-XXL font mobileorg-dynamic-type-light-theme
iPad Pro 11 Dark iPad Pro 11 Dark
Simulator Screen Shot - iPad Pro (11-inch) - 2019-10-16 at 23 50 31 Simulator Screen Shot - iPad Pro (11-inch) - 2019-10-16 at 23 50 24
webframp commented 4 years ago

This looks great, merging.

Sidenote: Awesome inclusion of the video, very helpful. I don't know if you watched it 100+ times but imgur says that many views have happened. So maybe there's a few interested lurkers on this repo 😀