Drop support for anything below iOS 12

dive commented 4 years ago

Hello there,

Okay, this one is huge in terms of LOC but quite simple (resolved #250).

Main changes

Switched to IPHONEOS_DEPLOYMENT_TARGET = 12.0;
Fixed all deprecations and warnings due to the migration to iOS 12 as a deployment target;
DocumentViewController reimplemented in Swift (PreviewViewController) to get rid of deprecated UIWebView usages;
Common build settings for all targets extracted to Global.shared.xcconfig;
Removed duplicated options from .xcodeproj;
Fixed HTML annotation for a viewport to render HTML properly on mobile devices;
Completed the switch to ARC (no more retain/release/etc.);
Enabled all useful Clang warnings/checks and fixed all consequences.

Regression

There was a feature to restore the scroll position within the HTML that was opened in the previous sessions but, after some checks, I realised that it never worked as expected. I removed this functionality due to complexity and doubtful benefit. Let me know if I need to restore it.

Disclaimer

I have tested all possible scenarios, check everything with Leaks & Performance profiles and did not notice any problems (or they were fixed within the branch). My only concern that there can be something wrong with the distribution to the AppStore. Let me know if this is a case and I will fix it.

webframp commented 4 years ago

@dive will take time to review this asap, but I agree with the changes for sure. Thanks!

webframp commented 4 years ago

@dive this change is live in TestFlight now. Sorry for the delay, it’s been a crazy couple of weeks and time has flown by

MobileOrg / mobileorg