Configs for simple models

MobileTeleSystems / RecTools

RecTools - library to build Recommendation Systems easier and faster than ever before

Apache License 2.0

287 stars 37 forks source link

Configs for simple models #178

Closed mikesokolovv closed 3 months ago

mikesokolovv commented 3 months ago

Description

Added model configs for EASE, Random and PureSVD models
Moved RandomState serialization to models/base.py

Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Optimization

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (3246ce7) to head (f6840d8).

Additional details and impacted files

```diff @@ Coverage Diff @@ ## feature/model_configs #178 +/- ## ======================================================= Coverage 100.00% 100.00% ======================================================= Files 56 56 Lines 3519 3555 +36 ======================================================= + Hits 3519 3555 +36 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

feldlime commented 3 months ago

Hi, thanks for PR!
Could you please give it a more relevant name? "Additional" is quite ambiguous; for me, it sounds like "optional."
Also, please separate changes in the description into 2 bullet points (added configs and moved rs)

feldlime commented 3 months ago

Could you please give it a more relevant name? "Additional" is quite ambiguous; for me, it sounds like "optional."

By this I wanted to say that "additional" sounds like "optional", but these configs are not "optional" and hence not "additional". So, please, give to this PR some meaningful name, and better do not connect it with the branch name since it's already different. You can name it Configs for simple models, it'd be fine.
Sorry for confusion.