Use nmslib-metabrainz for Python 3.11 and upper

MobileTeleSystems / RecTools

RecTools - library to build Recommendation Systems easier and faster than ever before

Apache License 2.0

273 stars 34 forks source link

Use nmslib-metabrainz for Python 3.11 and upper #180

Closed chezou closed 3 weeks ago

chezou commented 1 month ago

Description

The official nmslib doesn't provide wheels for Python 3.11 and 3.12. For convenience, let's allow the use of the forked version wheel, i.e., nmslib-metabrainz.

Type of change

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Optimization

How Has This Been Tested?

Before submitting a PR, please check yourself against the following list. It would save us quite a lot of time.

Have you read the contribution guide?
- Yes
Have you updated the relevant docstrings? We're using Numpy format, please double-check yourself
- No need to update docstring
Does your change require any new tests?
- No
Have you updated the changelog file?

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (9b3992e) to head (72d14b8). Report is 65 commits behind head on main.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #180 +/- ## =========================================== Coverage 100.00% 100.00% =========================================== Files 45 56 +11 Lines 2242 3451 +1209 =========================================== + Hits 2242 3451 +1209 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

feldlime commented 3 weeks ago

@chezou Nice solution, thanks!