MobilityData / gbfs-json-schema

JSON Schema for GBFS feeds, managed by MobilityData. The versions are organized by folders. CC BY 4.0
Apache License 2.0
23 stars 24 forks source link

Feat/109 java language bindings #110

Closed Alessandro100 closed 2 months ago

Alessandro100 commented 2 months ago

Fixes https://github.com/MobilityData/gbfs-json-schema/issues/109

This PR merges the repo https://github.com/entur/gbfs-java-model big thanks to @testower 🎉

Whats been done in this PR

Items to follow up on

CLAassistant commented 2 months ago

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
2 out of 3 committers have signed the CLA.

:white_check_mark: Alessandro100
:white_check_mark: testower
:x: renovate[bot]
You have signed the CLA already but the status is still pending? Let us recheck it.

jcpitre commented 2 months ago

I think overall this PR proves that we can build the jars and upload them to Sonatype. As evidenced by the many comments we will need to refine this to have a release strategy and make it part of our pipeline

jcpitre commented 2 months ago

I would have liked like to see the example (thanks @testower) be compiled and running though

testower commented 2 months ago

There are automated tests in the project that essentially do this. Maybe I misunderstood.