search

MobilityData / gbfs-json-schema

JSON Schema for GBFS feeds, managed by MobilityData. The versions are organized by folders. CC BY 4.0
Apache License 2.0
23 stars 24 forks source link

chore: add generateBuilders #121

Closed dersvenhesse closed 1 month ago

dersvenhesse commented 2 months ago

This PR adds the option generateBuilders to jsonschema2pojo since those make the usage of the generated models much more fun. Additionally, a link in the documentation is fixed.

dersvenhesse commented 2 months ago

For consistency I would suggest adding builders to these classes as well: https://github.com/MobilityData/gbfs-json-schema/tree/master/models/java/gbfs-java-model/src/main/java/org/mobilitydata/gbfs/v2_3/gbfs (same with v2_2)

I agree, hence I already added generateBuilders three times in pom.yml.

testower commented 2 months ago

I agree, hence I already added generateBuilders three times in pom.yml.

The classes I pointed to are not generated, so you need to add them manually. The generated sources are not checked in to the repo.

dersvenhesse commented 1 month ago

I'm closing this PR. I was confused with exactly these not generated classes without a builder, the other ones already provide builders.