search

MobilityData / gbfs-validator

The canonical GBFS validator. Maintained by the GBFS community, facilitated by MobilityData.
https://gbfs-validator.mobilitydata.org/
Apache License 2.0
18 stars 12 forks source link

feat: Enhance cli command line #107

Closed davidgamez closed 1 year ago

davidgamez commented 1 year ago

Description

In this PR, the cli.js file is enhanced with additional parameters, help messages, and error handling. The following parameters were added:

Usage: cli [OPTIONS]...

Options:
  -v, --version                    output the version number
  -u, --url <feed_url>          URL of the GBFS feed
  -vb, --verbose                   Verbose mode prints debugging console logs
  -s, --save-report <report_path>  Local path to output report file
  -pr, --print-report <yes_no>     Print report to standard output (choices: "yes", "no", default: "yes")
  -h, --help                       display help for command

Tasks pending before Ready

netlify[bot] commented 1 year ago

Deploy Preview for gbfs-validator ready!

Name Link
Latest commit cadabd54fe1db09375936e07b4a90bd4481c541a
Latest deploy log https://app.netlify.com/sites/gbfs-validator/deploys/64a5b694bf0f7c0008c73443
Deploy Preview https://deploy-preview-107--gbfs-validator.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

davidgamez commented 1 year ago

Thanks for this PR, it's a great improvement. I made 2 personal remarks, and maybe we can add a "summary" option to only have the summary?

Hi @PierrickP, can you expand on what information might be interesting to have in the summary response? I might defer this task to a follow-up PR.

PierrickP commented 1 year ago

@davidgamez On summary (based on https://github.com/MobilityData/gbfs-validator/pull/101) i would like if the feed is valid or not, versions, and the number of errors (distinct and total, part of https://github.com/MobilityData/gbfs-validator/pull/106).

davidgamez commented 1 year ago

@davidgamez On summary (based on #101) i would like if the feed is valid or not, versions, and the number of errors (distinct and total, part of #106).

@PierrickP, thanks for the response. I'll have this as a follow-up task after the mentioned PRs are reviewed and merged.