MobilityData / gbfs-validator

The canonical GBFS validator. Maintained by the GBFS community, facilitated by MobilityData.
https://gbfs-validator.mobilitydata.org/
Apache License 2.0
18 stars 12 forks source link

Fix required boolean (invalid) with required array #114

Closed richfab closed 1 year ago

richfab commented 1 year ago

What is it about?

The JSON schema used for GBFS feed validation was using an invalid property. The property required must take an array (reference) but it was taking a boolean.

The GBFS JSON schema was fixed in Replace required with boolean (invalid) to array.

This PR updates the schema in gbfs-validator.

Why does it matter?

A provider (TIER) is trying to update their GBFS feeds to v3.0, which is great! Unfortunately our validator is not so helpful now because it says the feed is valid although it's not. This PR will help the provider fix their feed.

Screenshots

https://data-sharing.tier-services.io/tier_paris/gbfs/3.0 image

Before After
image image
The validation report says gbfs.json is valid although it is not. The validation report correctly shows gbfs.json as invalid due to the extra en level.
netlify[bot] commented 1 year ago

Deploy Preview for gbfs-validator ready!

Name Link
Latest commit 4bb43a76c057d39da40c4df231fce15b212451ba
Latest deploy log https://app.netlify.com/sites/gbfs-validator/deploys/64a82c3ae30813000809ca58
Deploy Preview https://deploy-preview-114--gbfs-validator.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

CLAassistant commented 1 year ago

CLA assistant check
All committers have signed the CLA.