search

MobilityData / gbfs-validator

The canonical GBFS validator. Maintained by the GBFS community, facilitated by MobilityData.
https://gbfs-validator.mobilitydata.org/
Apache License 2.0
18 stars 12 forks source link

Upgrades netlify-cli to remove static-server dependency #145

Closed richfab closed 9 months ago

richfab commented 10 months ago

Fixes https://github.com/MobilityData/gbfs-validator/issues/134

Steps taken:

  1. Set netlify-cli dependency to ^13.0.0 (first major version that does not include static-server) in devDependencies in package.json
  2. Run yarn install locally
  3. Test that the website builds locally with yarn dev ✅
  4. Commit and push the changes made to package.json and yarn.lock
  5. The automated unit tests fail ❌
netlify[bot] commented 10 months ago

Deploy Preview for gbfs-validator failed.

Name Link
Latest commit 431e859b2ada10ccdc456390b17ff07c926edbd6
Latest deploy log https://app.netlify.com/sites/gbfs-validator/deploys/653fdc343a505b00088e82be
richfab commented 10 months ago

The website builds locally but this error occurs when validating a feed:

image

If someone has some tips, feel free to help 🙏 Thank you!

EDIT: The error described above was due to my local env, not to the netlify-cli version.

testower commented 10 months ago

I can have a look @richfab

testower commented 10 months ago

I was able to pin the error in the install step down to the upgrade from v13 to v14, but can't really understand why.

The website builds locally but this error occurs when validating a feed:

This happens even in master. I think the problem is that you have to authenticate with netlify for this to work.

testower commented 9 months ago

🥶

Very strange, the unit tests passed with v13 here https://github.com/entur/gbfs-validator/actions/runs/6671621967/job/18133905807

richfab commented 9 months ago

In my previous local tests, the argument -- filter website was causing the feed validation error.

Here are the next steps I took:

  1. Used @testower tests in https://github.com/MobilityData/gbfs-validator/pull/146 to see that ^13.0.0 is the first major version that does not include static-server.
  2. Set netlify-cli dependency to ^13.0.0 in devDependencies in package.json
  3. Run yarn install locally
  4. Test that the website builds locally with yarn dev ✅
  5. Commit and push the changes made to package.json and yarn.lock
  6. The automated unit tests fail ❌

The unit tests seem to fail when trying to install esbuild https://github.com/MobilityData/gbfs-validator/actions/runs/6695935881/job/18195967695#step:4:48.

Due to the low priority of this issue (https://github.com/MobilityData/gbfs-validator/issues/134#issuecomment-1751315193), I will close this draft PR for now.

richfab commented 9 months ago

🥶

Very strange, the unit tests passed with v13 here https://github.com/entur/gbfs-validator/actions/runs/6671621967/job/18133905807

Very strange indeed 🤔