Closed davidgamez closed 9 months ago
Name | Link |
---|---|
Latest commit | da781d329cc7db71e3f80984f7e08a418c0e5657 |
Latest deploy log | https://app.netlify.com/sites/gbfs-validator/deploys/6542aad668540e0008ce6a08 |
Deploy Preview | https://deploy-preview-148--gbfs-validator.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
It looks like the unit tests passed but the preview deploy failed. Should node-gyp
be added to package.json?
It looks like the unit tests passed but the preview deploy failed. Should
node-gyp
be added to package.json?
The unit test was fixed by adding the node-gyp to the GH actions. I'm still looking into the Netlify issue. The root cause can be related to "old" vue libraries, but nothing firm at this point.
Description
The
netlify-cli
hasn't been upgraded since the 10th version. In this PR, the netlify-cli is upgraded to15.11.0
. The intention was to upgrade it to the latest version. Unfortunately, there is a breaking change on 16.0.0 that prevents us from going over16.0.0
version without changing the structure of the folders in our monorepo setup. I'm proposing to stop in15.11.0
and address the upgrade later. More info: https://github.com/netlify/cli/issues/5977Fixes #134
Previous issues with Netlify builds
While upgrading the
netlify-cli
, we encountered an issue where netlify-cli dependencies were removed from the node_modules on the remote netlify builds. Locally, builds passed without problems, but not remotely. I fixed and added the nohoist behavior to the netlify-cli library, preventing yarn from removing dependencies needed by the cli library. Related yarn issues: https://github.com/yarnpkg/yarn/issues/4462, https://github.com/yarnpkg/yarn/issues/5230 and https://github.com/yarnpkg/yarn/issues/5580