search

MobilityData / gbfs-validator

The canonical GBFS validator. Maintained by the GBFS community, facilitated by MobilityData.
https://gbfs-validator.mobilitydata.org/
Apache License 2.0
18 stars 12 forks source link

Missing required files and API results #170

Closed AntoineAugusti closed 4 months ago

AntoineAugusti commented 6 months ago

Follow up of #127 and the fix introduced in #169

What is the issue and why is it an issue?

When a file is missing but required, the API now says 

"summary": {
  "errorsCount": 0,
  "hasErrors": true
}

image

which seems unexpected.

Example

Proposed fix

errorsCount should be the sum of GBFS errors + the number of missing required files

jcpitre commented 4 months ago

Some work has been done on a similar issue: https://github.com/MobilityData/gbfs-validator/pull/169

AntoineAugusti commented 4 months ago

Thank you for the fix @Alessandro100! It works: example