Closed Alessandro100 closed 2 months ago
Name | Link |
---|---|
Latest commit | e1ffa150049060256a607330d89f459f7bedc7fe |
Latest deploy log | https://app.netlify.com/sites/gbfs-validator/deploys/666068897874fc0008178ae5 |
Deploy Preview | https://deploy-preview-188--gbfs-validator.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
There was an issue when installing the npm package
npm i gbfs-validator --save
after the submodule addition. I discovered from the package.jsonpostinstall
script will trigger when users install the package usingnpm i gbfs-validator --save
. This caused an error where it would try to update the submodules when trying to download the package.Solution The
prepare
lifecycle script will trigger a submodule update on a localnpm install
but NOT when a user downloads the packagenpm i gbfs-validator --save
. It will also trigger just beforenpm publish
. This is the functionality we wanted from the beginningNote: I deployed version 1.0.11 locally to make sure this fix works, and it does!