MobilityData / gbfs-validator

The canonical GBFS validator. Maintained by the GBFS community, facilitated by MobilityData.
https://gbfs-validator.mobilitydata.org/
Apache License 2.0
18 stars 12 forks source link

fix: make it possible to validate v1.0 feeds #49

Closed testower closed 3 years ago

testower commented 3 years ago

v1.0 does not have version fields so assuming that feeds without it means it is version 1.0

Proposed solution to #48

netlify[bot] commented 3 years ago

❌ Deploy Preview for wizardly-engelbart-5c48ca failed.

🔨 Explore the source changes: c6a55a84fb27b952e5f729f70cdc5fa57a64caeb

🔍 Inspect the deploy log: https://app.netlify.com/sites/wizardly-engelbart-5c48ca/deploys/6177f4842e2895000781439d

netlify[bot] commented 3 years ago

❌ Deploy Preview for kind-pike-a3f3f8 failed.

🔨 Explore the source changes: c6a55a84fb27b952e5f729f70cdc5fa57a64caeb

🔍 Inspect the deploy log: https://app.netlify.com/sites/kind-pike-a3f3f8/deploys/6177f48481f0bf0007bbb12d

netlify[bot] commented 3 years ago

✔️ Deploy Preview for unruffled-hugle-914373 ready!

🔨 Explore the source changes: c6a55a84fb27b952e5f729f70cdc5fa57a64caeb

🔍 Inspect the deploy log: https://app.netlify.com/sites/unruffled-hugle-914373/deploys/6177f484156829000829e235

😎 Browse the preview: https://deploy-preview-49--unruffled-hugle-914373.netlify.app

netlify[bot] commented 3 years ago

❌ Deploy Preview for wizardly-lichterman-770f54 failed.

🔨 Explore the source changes: c6a55a84fb27b952e5f729f70cdc5fa57a64caeb

🔍 Inspect the deploy log: https://app.netlify.com/sites/wizardly-lichterman-770f54/deploys/6177f484a9509e000789f113

netlify[bot] commented 3 years ago

❌ Deploy Preview for competent-payne-690ca9 failed.

🔨 Explore the source changes: c6a55a84fb27b952e5f729f70cdc5fa57a64caeb

🔍 Inspect the deploy log: https://app.netlify.com/sites/competent-payne-690ca9/deploys/6177f484769c040007367a0f

PierrickP commented 3 years ago

Thanks @testower

@isabelle-dr the schema for v1.0 was updated/fixed. When https://github.com/MobilityData/gbfs-json-schema is re-organized, keep in mind to use theses fixes

isabelle-dr commented 2 years ago

Thank you for this contribution @testower! I've opened #53 on the Json-Schema repo to make sure we include it in the update.