MobilityData / gbfs-validator

The canonical GBFS validator. Maintained by the GBFS community, facilitated by MobilityData.
https://gbfs-validator.mobilitydata.org/
Apache License 2.0
18 stars 12 forks source link

Remove requirement patch for default_pricing_plan_id #72

Closed testower closed 2 years ago

testower commented 2 years ago

Solves #71

netlify[bot] commented 2 years ago

Deploy Preview for wizardly-lichterman-770f54 canceled.

Name Link
Latest commit c4fb6860cb57ed6c65f37a2e76fd32bf8ba7a0e6
Latest deploy log https://app.netlify.com/sites/wizardly-lichterman-770f54/deploys/624ee9dee613810009cfdfd9
netlify[bot] commented 2 years ago

Deploy Preview for competent-payne-690ca9 failed.

Name Link
Latest commit c4fb6860cb57ed6c65f37a2e76fd32bf8ba7a0e6
Latest deploy log https://app.netlify.com/sites/competent-payne-690ca9/deploys/624ee9de1506ec0008fbd794
netlify[bot] commented 2 years ago

Deploy Preview for gbfs-validator ready!

Name Link
Latest commit c4fb6860cb57ed6c65f37a2e76fd32bf8ba7a0e6
Latest deploy log https://app.netlify.com/sites/gbfs-validator/deploys/624ee9de05f657000810e993
Deploy Preview https://deploy-preview-72--gbfs-validator.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify[bot] commented 2 years ago

Deploy Preview for kind-pike-a3f3f8 failed.

Name Link
Latest commit c4fb6860cb57ed6c65f37a2e76fd32bf8ba7a0e6
Latest deploy log https://app.netlify.com/sites/kind-pike-a3f3f8/deploys/624ee9de4b23fa0008c8b6ff
netlify[bot] commented 2 years ago

Deploy Preview for wizardly-engelbart-5c48ca failed.

Name Link
Latest commit c4fb6860cb57ed6c65f37a2e76fd32bf8ba7a0e6
Latest deploy log https://app.netlify.com/sites/wizardly-engelbart-5c48ca/deploys/624ee9def149d2000926fff4
netlify[bot] commented 2 years ago

Deploy Preview for unruffled-hugle-914373 ready!

Name Link
Latest commit c4fb6860cb57ed6c65f37a2e76fd32bf8ba7a0e6
Latest deploy log https://app.netlify.com/sites/unruffled-hugle-914373/deploys/624ee9de0e46d90008070455
Deploy Preview https://deploy-preview-72--unruffled-hugle-914373.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

PierrickP commented 2 years ago

Thanks @testower :bow:

testower commented 2 years ago

Cheers @PierrickP , seems like unit tests don't run since PR is from fork, I'm going to double check locally though

testower commented 2 years ago

Ok I found I had to remove a test condition as well, but should be all good now.

PierrickP commented 2 years ago

@testower oups, i didn't checked the result of netlify. I don't know why it so verbose on this repository ..

PierrickP commented 2 years ago

4:16:46 PM: Build exceeded maximum allowed runtime

but doesn't mind there are a problem with the current code :\

testower commented 2 years ago

Yes seems like ajv is having issue parsing the schema, even v2.2 now. I'm trying to figure out what's going on.

PierrickP commented 2 years ago

I just checked locally with your branch, i don't have any error on unit test and manually with a feed (v2.2). Try to remove your node_module and run yarn one more time

testower commented 2 years ago

Yeah I am having trouble even with master branch. Unit tests are ok though

PierrickP commented 2 years ago

Can you share with me the feed are you testing with ? (here / mobilitydata slack or my email)

testower commented 2 years ago

Any feed. I Get error from ajv: Error compiling schema. I will try to reset everything

testower commented 2 years ago

Seems like everything is A-OK on my side now as well. Unrelated problems. What's up with alle the netlify failures?

isabelle-dr commented 2 years ago

I'm not sure... πŸ€” Are we OK to merge this PR?

testower commented 2 years ago

I think it is ok. I don’t know what’s up with the Netlify messages.