search

MobilityData / gbfs-validator

The canonical GBFS validator. Maintained by the GBFS community, facilitated by MobilityData.
https://gbfs-validator.mobilitydata.org/
Apache License 2.0
18 stars 12 forks source link

Validate for both lowercase and uppercase enums? #88

Closed josee-sabourin closed 1 year ago

josee-sabourin commented 1 year ago

The spec states that Enum values SHOULD be lowercase.. As a reminder the spec uses RFC 2119 for requirement level language.

The validator is flagging errors in datasets that use uppercase enum values. Example here.

Because the lowercase is recommended and not required (and effectively a best practice), should the validator consider feeds using uppercase as valid? This opens the question on whether the validator should validate for best practices, or just the specification.

testower commented 1 year ago

Wow, I actually didn't realize the spec said SHOULD on this matter. This makes it quite inconvenient for deserializing. Any chance we could propose to change this to MUST for 3.0?

josee-sabourin commented 1 year ago

Absolutely - I will open the PR right now and tag you in it.

josee-sabourin commented 1 year ago

For anyone who is not following over on the GBFS repository - the PR addressing this change is open for a vote.

josee-sabourin commented 1 year ago

Closing this as the PR on the specification has passed!