MobilityData / gbfs-validator

The canonical GBFS validator. Maintained by the GBFS community, facilitated by MobilityData.
https://gbfs-validator.mobilitydata.org/
Apache License 2.0
18 stars 12 forks source link

Unable to validate Link Granada #90

Closed josee-sabourin closed 6 months ago

josee-sabourin commented 1 year ago

Error when validating https://mds.linkyour.city/gbfs/es_granada/gbfs.json. "Sorry, this version is not yet implemented or not detectable !", even when specifying the version, same error message.

PierrickP commented 1 year ago

They block the default Got User-Agent

curl -I -H 'User-Agent: got (https://github.com/sindresorhus/got)' https://mds.linkyour.city/gbfs/es_granada/gbfs.json

return 500 But

curl -I https://mds.linkyour.city/gbfs/es_granada/gbfs.json

Works

We could change our user-agent to allow us to be properly identified (eg: gbfs-validator (https://github.com/MobilityData/gbfs-validator)) It is not bullet proof. They can still block it.

josee-sabourin commented 1 year ago

@ezmckinn can you provide any insight here? Would Superpedestrian prefer a more identifiable user-agent?

ezmckinn commented 1 year ago

Hi @josee-sabourin and @richfab — thanks for raising this. I actually have struggled to use the GBFS validator in the past, for our own spot-checking, so we'll be glad to work on this. I will file a bug ticket internally and provide on updates on this thread as the fix is processed.

richfab commented 1 year ago

Hi @ezmckinn, Do you have an update on the internal bug ticket? We're happy to provide support if Superpedestrian sees value in using the GBFS validator on its feeds. Thanks

davidgamez commented 6 months ago

For consistency between MobilityData validators, let's use a similar pattern described here. In this case user agent should be: User-Agent: MobilityData GBFS-Validator/{VALIDATOR_VERSION} ({NODE_VERSION})

richfab commented 6 months ago

Fixed by https://github.com/MobilityData/gbfs-validator/pull/177

Alessandro100 commented 6 months ago

With the latest version bump it should be working now fixing pr: https://github.com/MobilityData/gbfs-validator/pull/182

Screenshot 2024-04-17 at 11 11 32