MobilityData / gbfs-validator

The canonical GBFS validator. Maintained by the GBFS community, facilitated by MobilityData.
https://gbfs-validator.mobilitydata.org/
Apache License 2.0
18 stars 12 forks source link

Validator does not flag additional fields as invalid #93

Closed josee-sabourin closed 9 months ago

josee-sabourin commented 1 year ago

Certain feeds with additional non-GBFS fields are being checked as valid. Example: Citibike includes fields in station_information.json like electric_bike_surcharge_waiver and external_id, but the validation report says no errors.

I believe this might actually be an issue with the schemas and not the validator itself. I am opening the issue on both repositories to be sure.

My initial instinct for a solution would be to add an additionalProperties: false to the schemas, but would like to make sure before opening a PR.

richfab commented 9 months ago

Duplicate of https://github.com/MobilityData/gbfs-validator/issues/50