MobilityData / gtfs-realtime-bindings

Language bindings generated from the GTFS Realtime protocol buffer spec for popular languages.
Apache License 2.0
370 stars 127 forks source link

updated nodejs dependencies, moved local build steps for codegen to docker, general improvements #103

Closed jameslinjl closed 1 year ago

jameslinjl commented 1 year ago

Noticed a couple of issues within the nodejs code bindings:

jameslinjl commented 1 year ago

@derhuerst thanks for the feedback!! your suggestions make sense to me and i have implemented changes to address :)

jameslinjl commented 1 year ago

small poke @isabelle-dr - would be great to get some 👀 from someone on MobilityData side!

isabelle-dr commented 1 year ago

Thanks for the ping @jameslinjl!

I will go ahead and merge this PR since it looks like all the review comments have been addressed. Many thanks to @derhuerst and @gauthier-th for the reviews 🙏

jameslinjl commented 1 year ago

thanks @isabelle-dr ! when convenient, it would be great for someone with write permissions for the NPM package to publish a new version of the package (should just be following these instructions)

isabelle-dr commented 1 year ago

@fredericsimard, is this something you can do? 😊

fredericsimard commented 1 year ago

@isabelle-dr If you're asking me if I have login credentials on NPM's website, no I do not. I don't even know what this is. I've looked in all vaults, nothing with NPM or node in them.

gauthier-th commented 1 year ago

@bdferris @barbeau I saw you published previous versions of the package on NPM. Could you help us on this please?