Closed jameslinjl closed 1 year ago
@derhuerst thanks for the feedback!! your suggestions make sense to me and i have implemented changes to address :)
small poke @isabelle-dr - would be great to get some 👀 from someone on MobilityData side!
Thanks for the ping @jameslinjl!
I will go ahead and merge this PR since it looks like all the review comments have been addressed. Many thanks to @derhuerst and @gauthier-th for the reviews 🙏
thanks @isabelle-dr ! when convenient, it would be great for someone with write permissions for the NPM package to publish a new version of the package (should just be following these instructions)
@fredericsimard, is this something you can do? 😊
@isabelle-dr If you're asking me if I have login credentials on NPM's website, no I do not. I don't even know what this is. I've looked in all vaults, nothing with NPM or node in them.
@bdferris @barbeau I saw you published previous versions of the package on NPM. Could you help us on this please?
Noticed a couple of issues within the
nodejs
code bindings:package-lock.json
file to further reduce generated code variation due to shifting of indirect dependency versions.package.json
that the codegen is to be performed with the latest Node.js LTS version (v18.12.1).0.0.7
. If this looks good to folks, would be great for someone with permissions to publish a new version of the library!