MobilityData / gtfs-realtime-bindings

Language bindings generated from the GTFS Realtime protocol buffer spec for popular languages.
Apache License 2.0
370 stars 127 forks source link

golang: update deps and move local build to docker #106

Closed jameslinjl closed 1 year ago

jameslinjl commented 1 year ago
jameslinjl commented 1 year ago

hey @bdferris ! any chance you can give this guy a review? i haven't had any luck finding other reviewers

jameslinjl commented 1 year ago

cc @bdferris-v2

bdferris-v2 commented 1 year ago

Getting close! Apologies for all the comments :)

jameslinjl commented 1 year ago

Getting close! Apologies for all the comments :)

No need to apologize! Feedback is always appreciated :D

bdferris-v2 commented 1 year ago

Apologies, I dropped offline for holiday vacations, but I am back now. This LGTM so I'm going to approve for merging.

That said, I'm going to add one last nit. Do with it what you will. The script name you chose update_protos.sh is slightly weirdly named to me because in Protocol Buffer land, "protos" are usually the .proto file itself or binary data encoded using that schema. Your script is updating the generated code bindings from the source proto file, not updating the proto file itself. So a more appropriate name might be update_bindings.sh or update_generated_code.sh or something similar. As I said, ultimately not that big a deal, but I move a lot of protos as a Googler, so it's triggering for me :)

jameslinjl commented 1 year ago

@bdferris-v2 no problem! the file name change makes a lot of sense to me, so i included a change there. excited to get this merged in :)

bdferris-v2 commented 1 year ago

Still LGTM. But one sad wrinkle. My review hasn't unblocked you for merging because it appears I don't have commit privileges on this repo :( I believe my old github account @bdferris has commit privileges, but I got locked out of that one a while back (don't lose your 2FA backup codes!). Normally, @isabelle-dr would fix this for us, but I think she's still out on vacation for the rest of the week.

Let me check to see if there is anyone who can get us unblocked in the meantime.

bdferris-v2 commented 1 year ago

Good news. I got my privileges updated so you are now free to merge! Thanks for the contribution :)

jameslinjl commented 1 year ago

@bdferris-v2 looks like the repo is configured so that I'm not allowed to click the button heh

Screen Shot 2023-01-04 at 2 06 08 PM
bdferris-v2 commented 1 year ago

Ah, well. I guess I can do the hard work of pressing the button.