docs: improved JS example (with node-fetch)

MobilityData / gtfs-realtime-bindings

Language bindings generated from the GTFS Realtime protocol buffer spec for popular languages.

Apache License 2.0

370 stars 127 forks source link

Closed gauthier-th closed 1 year ago

gauthier-th commented 1 year ago

Improvements for the JS example, as discussed in #104

gauthier-th commented 1 year ago

@jameslinjl @derhuerst I just added a note about node-fetch installation with NPM and ESM vs CJS. Can you give me your opinion on this please?

jameslinjl commented 1 year ago

@gauthier-th lgtm!

jameslinjl commented 1 year ago

@gauthier-th @derhuerst any other thoughts on this guy?

jameslinjl commented 1 year ago

@isabelle-dr we should be good-to-go for merging this documentation / example change!

isabelle-dr commented 1 year ago

Sounds good, thanks for working on this @gauthier-th 🎉