barbeau
commented
5 years ago We should add tests for VehiclePositions, TripUpdates, and Alerts protobuf files:
- VehiclePositions example file - https://github.com/google/gtfs-realtime-bindings/tree/master/java/src/test/resources/com/google/transit/realtime
- TripUpdates example - http://api.tampa.onebusaway.org:8088/trip-update
- Alerts example - https://cdn.mbta.com/realtime/Alerts.pb
Right now we do not have unit tests for the dotnet bindings: https://github.com/google/gtfs-realtime-bindings/tree/master/dotnet
This can potentially cause issues when we update the bindings if there have been changes in the toolchain - process for updating the bindings is described here: https://github.com/google/gtfs-realtime-bindings/blob/master/dotnet/UPDATING.md
For comparison, we currently have unit tests for the Java bindings, and the code can be seen here: https://github.com/google/gtfs-realtime-bindings/blob/master/java/src/test/java/com/google/transit/realtime/GtfsRealtimeTest.java
...which test the consumption of a sample bundled protobuf file included in this directory: https://github.com/google/gtfs-realtime-bindings/tree/master/java/src/test/resources/com/google/transit/realtime
These tests are run as part of the process for updating the Java bindings, as described here: https://github.com/google/gtfs-realtime-bindings/blob/master/java/UPDATING.md
We should implement similar unit tests in the .NET bindings so we can be confident we aren't breaking anything when we update the bindings.
Sample .NET code for consuming a protobuf file can be seen in the .NET README: https://github.com/google/gtfs-realtime-bindings/blob/master/dotnet/README.md#example-code