search

MobilityData / gtfs-realtime-bindings

Language bindings generated from the GTFS Realtime protocol buffer spec for popular languages.
Apache License 2.0
370 stars 127 forks source link

feat: Release version 0.0.8 to Maven Central #92

Closed maximearmstrong closed 2 years ago

maximearmstrong commented 2 years ago

Fixes #90 .

maximearmstrong commented 2 years ago

So it looks like we're using the manual release process instead of mvn release, which I think is ok (see more of my thoughts on this at #89 (comment)).

Yes, I thought it would be less error prone. More steps, but it seems fair if we can get clearer PRs and commits.

Could you update the release docs to reflect this? Right now they are still a TODO: https://github.com/MobilityData/gtfs-realtime-bindings/blob/master/java/UPDATING.md#every-release

Oh right. Done :)

Also, I think I should create a tag like this on the squashed commit created by merging this PR. Thoughts?

barbeau commented 2 years ago

Also, I think I should create a tag like this on the squashed commit created by merging this PR. Thoughts?

Oh, yes, thanks for flagging this. This is why we need release process notes :). You should create the tag from main branch after merging this PR. Can you add this step to the process as well?

A few other minor suggestions below as well:

1. Create a new branch from the `master` branch and use it to push a commit to change to release version (i.e., without the `-SNAPSHOT`).
2. Open a PR with this release version and merge it in the `master` branch.
3. Create a tag with the name and release version `gtfs-realtime-bindings-java-[X].[Y].[Z]` (Note the addition of `-java`)
3. Create a new branch from the `master` branch and use it to push a commit to change to the next snapshot version (e.g., from `0.0.1` to `0.0.2-SNAPSHOT`). 
4. Open a PR with this snapshot version and merge it in the `master` branch.
maximearmstrong commented 2 years ago

Oh, yes, thanks for flagging this. This is why we need release process notes :). You should create the tag from main branch after merging this PR. Can you add this step to the process as well?

Sure :) I updated the release process. If this is good for you, I will merge and create the tag.

barbeau commented 2 years ago

@maximearmstrong looks like the publish to Maven Central failed on the main branch (401 unauthorized): https://github.com/MobilityData/gtfs-realtime-bindings/runs/6717799345?check_suite_focus=true