search

MobilityData / gtfs-realtime-validator

Java-based tool that validates General Transit Feed Specification (GTFS)-realtime feeds
Other
44 stars 10 forks source link

Pass in the snapshot version from the command line #103

Open maximearmstrong opened 2 years ago

maximearmstrong commented 2 years ago

Summary:

The JAR snapshot version should be passed in from the command line to the pom.xml so it is adapted to an automated process. See initial suggestion here

Steps to reproduce:

Expected behavior:

The snapshot version in the pom.xml should be passed in by the command line. This can easily be done in a workflow.

Observed behavior:

Platform:

barbeau commented 2 years ago

And just to clarify, this was effectively implemented in the process of working on #85 - see this Action file: https://github.com/MobilityData/gtfs-realtime-validator/blob/ff3288d62cccb0570504fed975c3154dbd1b6ba0/.github/workflows/test_package.yml

...and this config with pom.xml: https://github.com/MobilityData/gtfs-realtime-validator/blob/ff3288d62cccb0570504fed975c3154dbd1b6ba0/pom.xml#L9

...which passes the version set in the GitHub Action (i.e., commit SHA) to the Maven build via:

mvn -B package --file pom.xml -DskipTests -Drevision=${{ steps.prep.outputs.versionTag }}

We'd want something similar to this, but we need to define the release process to know where exactly the version number is set programmatically.