MobilityData / gtfs-realtime-validator

Java-based tool that validates General Transit Feed Specification (GTFS)-realtime feeds
Other
38 stars 9 forks source link

fix: Bump frontend-maven-plugin for Mac M1 builds #108

Closed barbeau closed 2 years ago

barbeau commented 2 years ago

Summary:

As mentioned by @lionel-nj in https://github.com/MobilityData/gtfs-realtime-validator/issues/101, builds currently fail on an Apple Mac M1 due to an issue with the frontend-maven-plugin dependency - see https://github.com/eirslett/frontend-maven-plugin/issues/952#issuecomment-762163294.

As suggested in https://github.com/MobilityData/gtfs-realtime-validator/issues/101, this bumps the version of frontend-maven-plugin so it should build on Mac M1s now.

Closes https://github.com/MobilityData/gtfs-realtime-validator/issues/101.

Expected behavior:

Build on Mac M1s (and all other platforms).

Please make sure these boxes are checked before submitting your pull request - thanks!

isabelle-dr commented 2 years ago

After testing on my computer, here are the results:

Master branch:

Screen Shot 2022-03-04 at 11 06 43 AM

Branch from this PR:

Screen Shot 2022-03-04 at 11 07 21 AM

This seems to be fixing one part of the issue, but we still have the tests failing. I'm merging this PR and will now see if the change in #106 allows me to build the project with a Mac M1.