MobilityData / gtfs-realtime-validator

Java-based tool that validates General Transit Feed Specification (GTFS)-realtime feeds
Other
42 stars 10 forks source link

E022 : confusing message when dates are different #112

Open AntoineAugusti opened 2 years ago

AntoineAugusti commented 2 years ago

Summary:

The error message for E022 may be confusing when datetimes are not in the same day.

Got

trip_id 863852 stop_sequence 5 arrival_time 07:19:00 (1645683540) is less than previous stop arrival_time 06:49:00 (1645768140) - times must increase between two sequential stops

1645683540 is 24/02/2022 07:19:00 1645768140 is 25/02/2022 06:49:00

This is confusing at first because 07:19 is not less than 06:49 in general, but it can be if it's not the same dates.

Expected behavior:

When dates are different, include date details otherwise it's difficult to compare things when the output only includes hours. Or always display full datetimes.

Observed behavior:

Only times are included making the error message confusing.